Do not fail silently when unpacking large messages #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes msgpack#503 Raising ValueError matches the behaviour of the pure Python version. I'm not sure that this is the best place to raise this message; it might make more sense when reading headers or in `append_buffer` or something. It's also possible that we want to raise BufferFull instead of ValueError.
hauntsaninja
force-pushed
the
unpackbig
branch
3 times, most recently
from
9dfe12b to
5374110
Compare
|
#505 to fix the CI failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #503
Raising ValueError matches the behaviour of the pure Python version.
I'm not sure that this is the best place to raise this message; it might
make more sense when reading headers or in
append_bufferorsomething. It's also possible that we want to raise BufferFull instead
of ValueError.