Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: n8n-io/n8n
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: [email protected]
Choose a base ref
...
head repository: n8n-io/n8n
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: [email protected]
Choose a head ref
  • 5 commits
  • 30 files changed
  • 5 contributors

Commits on Dec 21, 2023

  1. fix(core): Handle empty executions table in pruning in migrations (#8121 

    )

In case someone manually prunes their executions table before upgrading
to 1.x, `MigrateIntegerKeysToString` should gracefully handle that,
instead of crashing the application.

## Review / Merge checklist
- [x] PR title and summary are descriptive
    @netroy @ivov
    netroy authored and ivov committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    6cbeb5d View commit details
    Browse the repository at this point in the history

  2. fix: Show public API upgrade CTA when feature is not enabled (#8109) 

    ## Summary
> Describe what the PR does and how to test. Photos and videos are
recommended.

Shows the public API upgrade CTA when the feature is not enabled. Now
trialing users in cloud would see the API on the settings menu and can
upgrade from there.

When public API feature disabled: 

<img width="1863" alt="image"
src="https://github.com/%3Ca%20href="https://github.com/n8n-io/n8n/assets/16496553/a9052f6b-151f-4ebb-80df-5ff2fa643e85">https://github.com/n8n-io/n8n/assets/16496553/a9052f6b-151f-4ebb-80df-5ff2fa643e85">

When public API feature enabled with no API key:

<img width="1861" alt="image"
src="https://github.com/%3Ca%20href="https://github.com/n8n-io/n8n/assets/16496553/fdfe7296-425e-4410-a8cb-f25535bc9df4">https://github.com/n8n-io/n8n/assets/16496553/fdfe7296-425e-4410-a8cb-f25535bc9df4">

When public API feature enabled with API key:

<img width="1423" alt="image"
src="https://github.com/%3Ca%20href="https://github.com/n8n-io/n8n/assets/16496553/a8426cbf-ff73-43c4-8c60-b00274bca46e">https://github.com/n8n-io/n8n/assets/16496553/a8426cbf-ff73-43c4-8c60-b00274bca46e">



## Related tickets and issues
[> Include links to **Linear ticket** or Github issue or Community forum
post. Important in order to close *automatically* and provide context to
r](https://linear.app/n8n/issue/ADO-1282/feature-api-page-missing-for-trial-users)eviewers.



## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
    @RicardoE105 @ivov
    RicardoE105 authored and ivov committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    fd27f73 View commit details
    Browse the repository at this point in the history

  3. fix(core): Remove circular dependency in WorkflowService and ActiveWo… 

    …rkflowRunner (#8128)

A circular dependency between `WorkflowService` and
`ActiveWorkflowRunner` is sometimes causing `this.activeWorkflowRunner`
to be `undefined` in `WorkflowService`.
Breaking this circular dependency should hopefully fix this issue.

- [x] PR title and summary are descriptive
- [ ] Tests included
    @netroy @ivov
    netroy authored and ivov committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    b8e72c4 View commit details
    Browse the repository at this point in the history

  4. refactor(core): Move error execution creation to execution service (n… 

    …o-changelog) (#8006)

Continue breaking down legacy helpers.

Note: `getUserById` is unused.
    @ivov
    ivov committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    95ea2f6 View commit details
    Browse the repository at this point in the history

  5. 🚀 Release 1.22.1 (#8130) 

    ##
[1.22.1](https://github.com/n8n-io/n8n/compare/[email protected]@1.22.1)
(2023-12-21)


### Bug Fixes

* **core:** Handle empty executions table in pruning in migrations
([#8121](#8121))
([6cbeb5d](6cbeb5d))
* **core:** Remove circular dependency in WorkflowService and
ActiveWorkflowRunner
([#8128](#8128))
([b8e72c4](b8e72c4))
* **editor**: Show public API upgrade CTA when feature is not enabled
([#8109](#8109))
([fd27f73](fd27f73))

Co-authored-by: ivov <[email protected]>
    @github-actions @ivov
    github-actions[bot] and ivov authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    675d4b6 View commit details
    Browse the repository at this point in the history
Loading