fix: avoid std.meta.Tuple #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SuSonicTH Will you take a look? I suspect this might help your |
|
The patch worked for me, now my project compiles without "evaluation exceeded 10000 backwards branches" error. |
|
@SuSonicTH Really glad to hear it! I'll try and fix up the CI such that this PR passes and give it a merge :) |
This patch removes the use of `std.meta.Tuple` for compile-time metaprogramming. It's not clear to me that the convenience it brings makes the use of `std.meta` worth it. In particular, parsing the arguments list twice (once for `TypeOfWrap` and once in `wrap`) seems like an obvious area for improvement.
robbielyman
force-pushed
the
push-pqvzpxwmlnuz
branch
from
dfe3b4d to
5577ff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the use of
std.meta.Tuplefor compile-time metaprogramming. It's not clear to me that the convenience it brings makes the use ofstd.metaworth it. In particular, parsing the arguments list twice (once forTypeOfWrapand once inwrap) seems like an obvious area for improvement.