Skip to content

Convert CBMAEstimator method to function - #658

Merged
tsalo merged 9 commits into
neurostuff:mainfrom
tsalo:other-from-tfce
Mar 21, 2022
Merged

Convert CBMAEstimator method to function#658
tsalo merged 9 commits into
neurostuff:mainfrom
tsalo:other-from-tfce

Conversation

@tsalo

@tsalo tsalo commented Mar 21, 2022

Copy link
Copy Markdown
Member

Closes None. This is mostly an effort to minimize the diff and clean up the changelog for #655.

Changes proposed in this pull request:

  • Standardize example header lengths.
  • Replace manual connectivity matrix definition with calls to scipy.ndimage.generate_binary_structure.
  • Convert CBMAEstimator._calculate_cluster_measures to a function.
  • Some miscellaneous docstring and spacing cleanup.
  • Document and test the vfwe_only fix from Reorganize and streamline examples #656.

@tsalo tsalo added documentation Improving documentation for the project refactoring Requesting changes to the code which do not impact behavior labels Mar 21, 2022
@codecov

codecov Bot commented Mar 21, 2022

Copy link
Copy Markdown

Codecov Report

Merging #658 (d091eb5) into main (bdc0363) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
+ Coverage   85.29%   85.33%   +0.04%     
==========================================
  Files          40       40              
  Lines        4542     4529      -13     
==========================================
- Hits         3874     3865       -9     
+ Misses        668      664       -4     
Impacted Files Coverage Δ
nimare/diagnostics.py 93.61% <100.00%> (-0.27%) ⬇️
nimare/meta/cbma/base.py 96.53% <100.00%> (+1.22%) ⬆️
nimare/meta/cbma/mkda.py 97.04% <100.00%> (-0.05%) ⬇️
nimare/meta/utils.py 52.80% <100.00%> (+5.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdc0363...d091eb5. Read the comment docs.

tsalo added 2 commits March 21, 2022 12:39
Also should have been part of neurostuff#656.
@tsalo
tsalo merged commit 470b8d3 into neurostuff:main Mar 21, 2022
@tsalo
tsalo deleted the other-from-tfce branch March 21, 2022 17:32
@jdkent jdkent added this to Planning Dec 19, 2025
@jdkent jdkent moved this to Done in Planning Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improving documentation for the project refactoring Requesting changes to the code which do not impact behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants