Refactor Correctors and remove statsmodels requirement

[tsalo]

Closes #667.

Changes proposed in this pull request:

• Replace calls to statsmodels multiple comparisons correction functions with PyMARE functions.
• Remove nimare.stats.fdr.
• Refactor Correctors somewhat.
  • Generic correction methods are now actual instance methods, with proper docstrings and everything!
  • Estimator methods explicitly override generic ones.
• Rename MKDAChi2.correct_fwe_bh to MKDAChi2.correct_fwe_indep (breaking change).
• Replace "fdr_bh" option with "bh" in decoder multiple comparisons correction (breaking change).

To do:

• Call the appropriate correction method within the Corrector based on the method parameter.
• Version directives.

[codecov]

Codecov Report

Merging #679 (af2e588) into main (d37c216) will decrease coverage by 0.11%.
The diff coverage is 87.50%.

❗ Current head af2e588 differs from pull request most recent head fe822ae. Consider uploading reports for the commit fe822ae to get more accurate results

@@            Coverage Diff             @@
##             main     #679      +/-   ##
==========================================
- Coverage   85.32%   85.21%   -0.12%     
==========================================
  Files          41       41              
  Lines        4503     4483      -20     
==========================================
- Hits         3842     3820      -22     
- Misses        661      663       +2     

Impacted Files	Coverage Δ
nimare/stats.py	98.97% <ø> (+4.74%)	⬆️
nimare/decode/discrete.py	92.34% <38.46%> (-4.27%)	⬇️
nimare/correct.py	94.28% <100.00%> (+1.21%)	⬆️
nimare/meta/cbma/mkda.py	96.96% <100.00%> (-0.13%)	⬇️
nimare/meta/utils.py	51.20% <0.00%> (-1.60%)	⬇️
nimare/meta/kernel.py	80.00% <0.00%> (-0.13%)	⬇️
nimare/io.py	95.07% <0.00%> (-0.08%)	⬇️
nimare/meta/cbma/base.py	95.63% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d37c216...fe822ae. Read the comment docs.

[jdkent]

Looks good!

Main comment is I'm curious if the method parameter documentation could be defined once and referenced in other places, Don't consider it a blocking review comment, but it's nice not to have to repeat yourself, maybe rst substitutions would do what you want? https://stackoverflow.com/questions/8320909/repeated-parameters-with-python-sphinx

[tsalo]

Main comment is I'm curious if the method parameter documentation could be defined once and referenced in other places, Don't consider it a blocking review comment, but it's nice not to have to repeat yourself, maybe rst substitutions would do what you want? https://stackoverflow.com/questions/8320909/repeated-parameters-with-python-sphinx

I think that's what nilearn does, and I certainly like it. Would you mind if I tackled that in a separate PR? I might open an issue about it.

[adelavega]

Looks good to me, although I wonder if these non-imaging basic functions should perhaps live in pyMARE?

[tsalo]

Looks good to me, although I wonder if these non-imaging basic functions should perhaps live in pyMARE?

That seems reasonable to me, but PyMARE doesn't use these methods at the moment, so we would probably only want to add them to that package if we also create a Corrector class within PyMARE as well.

[tsalo]

@adelavega I've moved the new functions to PyMARE. I'll make a release once the associated PR (neurostuff/PyMARE#87) is merged.

EDIT: I've released PyMARE 0.0.4rc1 and pinned it here.

[adelavega]

LGTM!

[tsalo]

I've opened an issue about the parameter definitions (#687), so I'm going to resolve the conflicts and merge this once CI passes.