improve update command
#163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Sep 19, 2025
Araq
reviewed
Sep 19, 2025
Araq
reviewed
Sep 19, 2025
src/basic/gitops.nim
Outdated
| return cc.strip() | ||
|
|
||
| proc isOutdated*(path: Path): (bool, int) = | ||
| proc isOutdated*(path: Path): Option[tuple[outdated: bool, newTags: int]] = |
There was a problem hiding this comment.
Fine for now but ideally the name becomes something like fetchNewTags.
There was a problem hiding this comment.
I renamed it hasNewTags and it returns an option now.
elcritch
added a commit
to elcritch/atlas
that referenced
this pull request
Oct 13, 2025
* update updates * update updates * update * update * update * update * update * swap to option to represent no answer * swap to option to represent no answer from isOutdated * swap to option to represent no answer from isOutdated * rename * rename * rename again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously update would only look for new tags. This breaks on repos not using tags for versioning. This PR improves it to first looks for tags, if none are found it will update the repo directly.
The repo update command has also been changed to
git fetch origin "refs/heads/*:refs/heads/*" "refs/tags/*:refs/tags/*"which will update origin as well as try to update any local branches. This should improve workflows. I left an option to only update the origin refs in case it causes trouble or it's wanted. Currently it's not plumbed out.Finally, fixed the documentation. There's only
atlas update.