RF: Fix for abc library Traversable class module
#1333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1333 +/- ##
=======================================
Coverage 92.20% 92.20%
=======================================
Files 98 98
Lines 12398 12398
Branches 2556 2556
=======================================
Hits 11431 11431
Misses 644 644
Partials 323 323 ☔ View full report in Codecov by Sentry. |
|
Sorry Chris, no idea how to solve the riddle here after inspecting the build logs. |
effigies
force-pushed
the
FixTraversableResourcesModule
branch
from
a4e0def to
908953d
Compare
Fix for `abc` library `Traversable` class module: import from
`importlib.resources.abc`.
Fixes:
```
/home/runner/work/nibabel/nibabel/nibabel/testing/__init__.py:30:
DeprecationWarning: 'importlib.abc.Traversable' is deprecated and slated for removal in Python 3.14
from importlib.abc import Traversable
```
raised for example at:
https://github.com/nipy/nibabel/actions/runs/9637811213/job/26577586721#step:7:157
Documentation:
https://docs.python.org/3/library/importlib.resources.abc.html#importlib.resources.abc.Traversable
effigies
force-pushed
the
FixTraversableResourcesModule
branch
from
b340ca5 to
7caef99
Compare
|
Down to 27K warnings (https://github.com/nipy/nibabel/actions/runs/9692730430/job/26746686623#step:7:376) from 29K (https://github.com/nipy/nibabel/actions/runs/9637811213/job/26577586721#step:7:434) 😟 with these fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for
abclibraryTraversableclass module: import fromimportlib.resources.abc.Fixes:
raised for example at:
https://github.com/nipy/nibabel/actions/runs/9637811213/job/26577586721#step:7:157
Documentation:
https://docs.python.org/3/library/importlib.resources.abc.html#importlib.resources.abc.Traversable