Skip to content

ENH: Create a crashfile even if 'stop_on_first_crash' is set - #2774

Merged
effigies merged 1 commit into
nipy:masterfrom
chrisgorgo:enh/crashfiles_order
Nov 10, 2018
Merged

ENH: Create a crashfile even if 'stop_on_first_crash' is set#2774
effigies merged 1 commit into
nipy:masterfrom
chrisgorgo:enh/crashfiles_order

Conversation

@chrisgorgo

Copy link
Copy Markdown
Member

This makes error reporting more consistent and helps building apps (such as fmriprep) on top of nipype.

@chrisgorgo
chrisgorgo requested a review from effigies November 10, 2018 03:20
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #2774 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2774      +/-   ##
==========================================
- Coverage    67.5%   67.48%   -0.03%     
==========================================
  Files         340      340              
  Lines       43271    43271              
  Branches     5364     5364              
==========================================
- Hits        29210    29201       -9     
- Misses      13360    13368       +8     
- Partials      701      702       +1
Flag Coverage Δ
#smoketests 50.6% <0%> (ø) ⬆️
#unittests 64.88% <33.33%> (-0.04%) ⬇️
Impacted Files Coverage Δ
nipype/pipeline/plugins/linear.py 88.57% <0%> (ø) ⬆️
nipype/pipeline/plugins/base.py 59.55% <100%> (ø) ⬆️
nipype/pipeline/plugins/legacymultiproc.py 60.5% <0%> (-4.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 199d9a6...0a6f6cd. Read the comment docs.

@effigies effigies added this to the 1.1.6 milestone Nov 10, 2018
@effigies
effigies merged commit 67d6212 into nipy:master Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants