Skip to content

Conversation

@cjbarth
Copy link
Collaborator

@cjbarth cjbarth commented Mar 6, 2024

There was only a single warning when linting, about the any type. Removing the any type in this case would be vary arduous, so we leave it as-is and remove the linting warning.

@cjbarth cjbarth added the chore Refactoring, etc. to keep code-rot in check. label Mar 6, 2024
@codecov
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.42%. Comparing base (cf541a5) to head (ccd5284).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #889   +/-   ##
=======================================
  Coverage   64.42%   64.42%           
=======================================
  Files           4        4           
  Lines         149      149           
  Branches       37       37           
=======================================
  Hits           96       96           
  Misses         30       30           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cjbarth cjbarth merged commit 2389a5e into node-saml:master Mar 6, 2024
@cjbarth cjbarth deleted the clean-types branch March 6, 2024 19:14
AlbertPangilinan pushed a commit to Foxquilt/foxden-saml-passport that referenced this pull request Sep 24, 2025
Eric-G-Ji pushed a commit to Foxquilt/foxden-saml-passport that referenced this pull request Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Refactoring, etc. to keep code-rot in check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant