Skip to content

Conversation

targos
Copy link
Member

@targos targos commented Aug 27, 2025

Refs: nodejs/node#59629

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@targos targos requested a review from a team as a code owner August 27, 2025 21:29
Copy link

vercel bot commented Aug 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Aug 27, 2025 9:30pm

@targos targos added the github_actions:pull-request Trigger Pull Request Checks label Aug 27, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Aug 27, 2025
@targos targos enabled auto-merge August 27, 2025 21:30
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.87%. Comparing base (a5ea254) to head (a8911a0).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8115      +/-   ##
==========================================
- Coverage   75.89%   75.87%   -0.03%     
==========================================
  Files         113      113              
  Lines        9459     9459              
  Branches      307      308       +1     
==========================================
- Hits         7179     7177       -2     
- Misses       2279     2281       +2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 27, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 89 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 99 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 97 🟢 93 🟢 100 🟢 100 🔗
/en/download 🟢 93 🟢 100 🟢 100 🟢 100 🔗
/en/download/archive/current 🟢 99 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

@targos targos added this pull request to the merge queue Aug 27, 2025
Merged via the queue into nodejs:main with commit 1117fb3 Aug 27, 2025
15 checks passed
@targos targos deleted the v24.7.0 branch August 27, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants