Skip to content

Explore support for async/dynamic chunk names (POC) #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Explore support for async/dynamic chunk names (POC) #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 38 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,18 @@ const updateSrcElement = (options, tag) => {
return tag;
};

const addCustomResourceHints = (options, scripts) => {
let hints = [];
scripts.forEach(script => {
if (options.dynamicChunks.preload) {
hints.push(createResourceHint('preload', null, script));
} else if (options.dynamicChunks.prefetch) {
hints.push(createResourceHint('prefetch', null, script));
}
});
return hints;
};

const addResourceHints = (options, tags) => {
return tags
.filter(hasScriptName)
Expand All @@ -133,13 +145,13 @@ const addResourceHints = (options, tags) => {
);
};

const createResourceHint = (rel, tag) => {
const createResourceHint = (rel, tag, customPath) => {
return {
tagName: 'link',
closeTag: true,
attributes: {
rel: rel,
href: getRawScriptName(tag),
href: customPath || getRawScriptName(tag),
as: 'script'
}
};
Expand Down Expand Up @@ -176,6 +188,30 @@ class ScriptExtHtmlWebpackPlugin {
addResourceHints(options, pluginArgs.body)
]);
}
if (shouldUpdateElements(options)) {
if (options.dynamicChunks) {
const chunkRegEx = /^chunk[.]/;
// Get the paths to dynamic chunks
const extractedChunks = compilation
.chunks
.reduce((chunks, chunk) => chunks.concat(chunk.files), [])
.filter(chunk => chunkRegEx.test(chunk));
// Default to 'head' as the position
if (options.dynamicChunks.position === 'body') {
debug(`${EVENT}: injecting <body> resource hints`);
pluginArgs.body = concat([
pluginArgs.body,
addCustomResourceHints(options, extractedChunks)
]);
} else {
debug(`${EVENT}: injecting <head> resource hints`);
pluginArgs.head = concat([
pluginArgs.head,
addCustomResourceHints(options, extractedChunks)
]);
}
}
}
debug(`${EVENT}: completed`);
callback(null, pluginArgs);
} catch (err) {
Expand Down