Update multi-dimentional array example in xray tutorial #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just something I noticed while reviewing the alt-text changes in the xray image processing tutorial:
The section on loading an "image stack" had a few points that could be improved on. In the first cell in the section, the images are loaded manually rather than programmatically, which is cumbersome and also error prone - for example, there should be 9 images in the final result instead of 8 given the 0-indexed numbering scheme, but img 002 was left out for some reason.
There is also a benchmarking section where appending images in a for-loop is compared to
np.stack
- however; this is an apple-to-oranges comparison because the former included the file IO in the loop whereas the latter did not. I also think that creating the arrays directly from the data rather than explicitly stacking pre-loaded 1-D arrays demonstrates the multi-dimensional concept more clearly by cutting out unnecessary steps.