Test failed deployment in integration test #119
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
project/integration_test.go
Outdated
| // Step 6: Deploy the project again (second deployment) | ||
| t.Log("Step 6: Deploying project again to create second deployment...") | ||
|
|
||
| err = ctx.deployProject(createdProject.ID, true, 60) | ||
| require.NoError(t, err, "Second deployment should succeed") | ||
| err = ctx.deployProject(createdProject.ID, false, 60) | ||
| require.Error(t, err, "Second deployment should fail due to non-existent image") | ||
|
|
||
| err = ctx.waitForProjectStatus(createdProject.ID, docker.ComposeProjectStatusRunning, 30*time.Second) | ||
| require.NoError(t, err, "Project should reach running status after second deployment") | ||
| // Project should be in failed state after failed deployment | ||
| err = ctx.waitForProjectStatus(createdProject.ID, docker.ComposeProjectStatusFailed, 30*time.Second) | ||
| require.NoError(t, err, "Project should be in failed state after failed deployment") |
There was a problem hiding this comment.
After corrupting compose.yaml the test polls waitForProjectStatus(..., docker.ComposeProjectStatusFailed, …) expecting the compose status to become "failed". ComposeProjectStatusFailed is only returned when at least one container is running while others are not, but in this scenario deployProject aborts before any containers start and GetStatus returns "stopped" (default when docker compose ps yields no running containers). The loop therefore times out on every run even though the deployment error is correctly surfaced. Consider asserting the domain deployment status or checking for ComposeProjectStatusStopped instead.
Useful? React with 👍 / 👎.
Ch00k
force-pushed
the
filed-deployment
branch
from
612d1ab to
35ac677
Compare
No description provided.