Recently, I am supplementing the test case for pushError() (src/lib_json/json_reader.cpp) and find it is a public and isolated interface. I couldn’t match it with a suitable test scenario.

By searching the related records of pusherror(), I found this interface was introduced into jsoncpp in #57 and #58. After that, @cdunn2001 reverted this commit since 0.8.0 version. But this pusherror() still exicted in the master branch and influence the later version.

In short, this public interface is a useless and harmless addition to jsoncpp. The submitter was not opposed to remove pusherror(). Maybe we could remove pusherror() in the current master branch. However, we could not exclude that some one is using this interface. So, I suggest:

1 Considering compatibility, deprecate the reader::pushError(). And I will supplement the corresponding test case by referring to the use case in #57.
2 Remove the OurReader::pusherror(). OurReader is an internal class and user cannot use this interface directly.