We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build break on Mac OS X with latest commit.
cmake .. ... make [ 23%] Built target jsoncpp_lib [ 41%] Built target jsoncpp_object [ 64%] Built target jsoncpp_static [ 76%] Built target jsontestrunner_exe [ 82%] Building CXX object src/test_lib_json/CMakeFiles/jsoncpp_test.dir/main.cpp.o <>/jsoncpp/src/test_lib_json/main.cpp:356:12: error: implicit conversion changes signedness: 'int' to 'Json::Value::ArrayIndex' (aka 'unsigned int') [-Werror,-Wsign-conversion] v.resize(n); ~~~~~~ ^ 1 error generated. make[2]: *** [src/test_lib_json/CMakeFiles/jsoncpp_test.dir/main.cpp.o] Error 1 make[1]: *** [src/test_lib_json/CMakeFiles/jsoncpp_test.dir/all] Error 2 make: *** [all] Error 2
The text was updated successfully, but these errors were encountered:
Interesting. I wonder how this passed our TravisCI gate? Should be a simple fix though.
I'm in Texas, with spotty internet connection right now. If you submit a PR, somebody will merge it.
Sorry, something went wrong.
Weird that I didn't notice it. I'm locally developing on Mac. I can fix it.
fix sign-conversion warning
823b3e0
Use ArrayIndex instead of int. Fixes #1266
fix sign-conversion warning (#1268)
b1bd848
Successfully merging a pull request may close this issue.
Build break on Mac OS X with latest commit.
The text was updated successfully, but these errors were encountered: