Skip to content

Build Break on Mac OS X #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MichaelDevine opened this issue Feb 12, 2021 · 2 comments · Fixed by #1268
Closed

Build Break on Mac OS X #1266

MichaelDevine opened this issue Feb 12, 2021 · 2 comments · Fixed by #1268
Labels
build or testing cmake, meson, continuous integration, or testing related

Comments

@MichaelDevine
Copy link

Build break on Mac OS X with latest commit.

cmake ..
...
make
[ 23%] Built target jsoncpp_lib
[ 41%] Built target jsoncpp_object
[ 64%] Built target jsoncpp_static
[ 76%] Built target jsontestrunner_exe
[ 82%] Building CXX object src/test_lib_json/CMakeFiles/jsoncpp_test.dir/main.cpp.o
<>/jsoncpp/src/test_lib_json/main.cpp:356:12: error: implicit conversion changes signedness: 'int' to
'Json::Value::ArrayIndex' (aka 'unsigned int') [-Werror,-Wsign-conversion]
v.resize(n);
~~~~~~ ^
1 error generated.
make[2]: *** [src/test_lib_json/CMakeFiles/jsoncpp_test.dir/main.cpp.o] Error 1
make[1]: *** [src/test_lib_json/CMakeFiles/jsoncpp_test.dir/all] Error 2
make: *** [all] Error 2

@cdunn2001
Copy link
Contributor

Interesting. I wonder how this passed our TravisCI gate? Should be a simple fix though.

I'm in Texas, with spotty internet connection right now. If you submit a PR, somebody will merge it.

@cdunn2001 cdunn2001 added the build or testing cmake, meson, continuous integration, or testing related label Feb 20, 2021
@BillyDonahue
Copy link
Contributor

Weird that I didn't notice it. I'm locally developing on Mac.
I can fix it.

BillyDonahue added a commit that referenced this issue Feb 20, 2021
Use ArrayIndex instead of int.  Fixes #1266
BillyDonahue added a commit that referenced this issue Feb 20, 2021
Use ArrayIndex instead of int.  Fixes #1266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build or testing cmake, meson, continuous integration, or testing related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants