Improve/standardize CMake config file creation #180

Activity

1. cdunn2001 commented on Feb 19, 2015

   

   cdunn2001

   on Feb 19, 2015

   Contributor

   More actions

   Ok. Let us know what you learn. I think we need to remain backward-compatible for older cmake for now, but it might be possible to includes "ifs" within the cmakefiles for that.
2. cdunn2001

   added

   enhancement

   on Feb 19, 2015
3. bradking commented on Feb 19, 2015

   

   bradking

   on Feb 19, 2015

   Contributor

   More actions

   The CMake manual contains an explanation of how to create packages:

   http://www.cmake.org/cmake/help/v3.2/manual/cmake-packages.7.html#creating-packages

   Directly creating a <pkg>Config.cmake file with install(EXPORT) was never the official or preferred way. Package configuration files have always been created with configure_file or similar approaches, and pre-dated CMake's ability to export/import targets. When install(EXPORT) was introduced then projects started using it to create a <pkg>Targets.cmake file (whose name is only a convention and has no meaning to CMake) and then loading it from the main <pkg>Config.cmake.

   There should be no compatibility issue for supporting older CMake versions if you switch to creating a jsoncppTargets.cmake file with install(EXPORT) and providing jsoncppConfig.cmake as a file that includes it. Furthermore then the new jsoncppConfig.cmake file should provide other information. See the above link about creating packages. Version information should also be provided in a jsoncppConfigVersion.cmake. That will allow applications that do find_package(jsoncpp CONFIG) to check variables like jsoncpp_VERSION to see the version number.
4. cdunn2001 commented on Feb 19, 2015

   

   cdunn2001

   on Feb 19, 2015

   Contributor

   More actions

   Sounds great! Could one of you write the patch?
5. bradking commented on Feb 19, 2015

   

   bradking

   on Feb 19, 2015

   Contributor

   More actions

   @rpavlik, if you work on this you could also consider naming the files jsoncpp-config.cmake, jsoncpp-config-version.cmake, and jsoncpp-targets.cmake. The lower case name seems more in the style of jsoncpp. Also CMake's find_package command has long documented support for the <pkg>-config.cmake naming alternative so even older CMake versions will still find it there.
6. bradking commented on Feb 26, 2015

   

   bradking

   on Feb 26, 2015

   Contributor

   More actions

   As discussed in Kitware/CMake#144, CMake 3.2 will not distribute a FindJsonCpp module as originally planned because it may conflict with existing code that does find_package(jsoncpp) looking for the current jsoncppConfig.cmake file. However, the only way for a CMake project to find jsoncpp reliably without having a copy of FindJsonCpp is if jsoncpp consistently provides the package configuration files so that a plain find_package(jsoncpp) call will always have a file to find. This means it would have to be done unconditionally and by all the build systems (LLVM provides one both with CMake and with autotools, for example). Currently jsoncppConfig.cmake is provided only by the CMake build system for jsoncpp and only conditionally.
7. cdunn2001

   added

   help wanted

   on Feb 26, 2015
8. cdunn2001 commented on Mar 6, 2015

   

   cdunn2001

   on Mar 6, 2015

   Contributor

   More actions

   For reference, old patches at SF:

   • https://sourceforge.net/p/jsoncpp/patches/22/
   • https://sourceforge.net/p/jsoncpp/patches/14/
9. rpavlik

   added a commit that references this issue on Apr 6, 2015

   Adds a Findjsoncpp.cmake file needed to find jsoncpp on Linux.

   f6847e8
10. fraillt commented on Mar 23, 2018

    

    fraillt

    on Mar 23, 2018

    More actions

    I would like to add one thing, regarding exporting targets.
    In modern cmake it is prefered to export targets to namespaces like this:

    find_package(jsoncpp)
    target_link_libraries(myexe PRIVATE JSONCPP::jsoncpp_lib_static)
    

    with this syntax, cmake knows that JSONCPP::jsoncpp_lib_static is cmake target, ant not some arbitrary library, so if you mistype library name at cmake will detect it at configure time.

    The change is realy small

    IF(JSONCPP_WITH_CMAKE_PACKAGE)
            INSTALL(EXPORT jsoncpp
                    NAMESPACE JSONCPP:: # <-- add this line, to export targets in namespace
                    DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/jsoncpp
                    FILE        jsoncppConfig.cmake)
    ENDIF()
    

    The problem is that, existing users after update should write
    target_link_libraries( ... JSONCPP::jsoncpp_lib_static) instead of
    target_link_libraries( ... jsoncpp_lib_static)
11. cdunn2001 commented on Mar 24, 2018

    

    cdunn2001

    on Mar 24, 2018

    Contributor

    More actions

    The problem is that, existing users after update should ...

    That's a pretty big problem. cmake support is only legacy. We use and recommend meson. I'd hate to break old cmake users when new cmake users have a good alternative.
12. cdunn2001

    closed this as completedon Mar 24, 2018