-
Notifications
You must be signed in to change notification settings - Fork 2.7k
1.7.4: pkg-config file (wrong includedir) #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It's apparently hard to make everyone happy... @tgurr can you provide the arguments you pass to cmake? Also, was 1.7.3 fine for you? Because as mentioned in #493, 1.7.3 was broken for Archlinux. For reference, here is the cmake invocation and resulting pkg-config file on Archlinux:
|
Here is what it looks like with 1.7.3:
The CMake arguments we pass:
This allows us to natively cross compile, e.g. x86_64 lands in /usr/x86_64-pc-linux-gnu, i686 in /usr/i686-pc-linux-gnu and so on. |
Ok, so you just need to build with By the way, you have the same problem I had, which is that @cdunn2001 maybe it's worth mentioning in the release notes that people customizing these variables (probably distribution packagers) may need to change absolute paths into relative paths? |
I've a problem setting
About |
We need you both to come to an agreement. I am not an expert on cmake and would rather not take this decision myself. |
Yes, I tried to work this out, but I'm no expert on cmake either. @tgurr as a workaround, you can patch |
What is recommended solution for this problem? Is it something that is going to be fixed in jsoncpp build script? |
On Gentoo, installed jsoncpp 1.7.7, and the pc-file looks like this:
Which leads to The build script looks like this: https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-libs/jsoncpp/jsoncpp-1.7.7.ebuild Are you saying that this is a distribution error and they should fix |
The build script you link to says:
But Archlinux installs headers in From what I see here in the CMake documentation this variable should probably be relative, not absolute. |
@zorun I actually tried to patch the How can we have both a correct .pc file and install the headers into a directory named by the package to avoid conflicts? |
With my pull request (#562), this issue is solved now in Gentoo, as |
Thanks! 1.8.0 works for me as well (passing -DCMAKE_INSTALL_INCLUDEDIR=include/jsoncpp results in a correct pkg-config file). |
Thanks a lot for the fix @SoapGentoo ! It still works fine for Arch Linux. |
In 1.7.2 everything looked okay:
and in 1.7.4 at least the includedir looks wrong to me:
The text was updated successfully, but these errors were encountered: