Skip to content

change the returned value of method [readToken] #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

dota17
Copy link
Member

@dota17 dota17 commented Aug 16, 2019

When I read the code, I found that the method [readToken] always return the true value.
But in other place, the returned value is used to judge.
For example, in the method [readObject]

while(...)
    initialTokenOK = readToken(tokenName);
if (!initialTokenOK)
    ....

So, it is a mistake for the returned value, I think.

@baylesj baylesj merged commit fd94025 into open-source-parsers:master Aug 26, 2019
@dota17 dota17 deleted the dev branch August 29, 2019 08:37
dawesc pushed a commit to EFTlab/jsoncpp that referenced this pull request Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants