clang-tidy cleanups 2 #1048
Merged
clang-tidy cleanups 2 #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found with hicpp-explicit-conversions Signed-off-by: Rosen Penev <[email protected]>
Found with readability-inconsistent-declaration-parameter-name Signed-off-by: Rosen Penev <[email protected]>
Found with modernize-use-equals-default Signed-off-by: Rosen Penev <[email protected]>
Found with readability-redundant-string-cstr Signed-off-by: Rosen Penev <[email protected]>
Found with readability-simplify-boolean-expr Signed-off-by: Rosen Penev <[email protected]>
|
Good for it. |
Found with modernize-pass-by-value Signed-off-by: Rosen Penev <[email protected]>
Found with hicpp-uppercase-literal-suffix Signed-off-by: Rosen Penev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.