Add option JSONCPP_WITH_EXAMPLE #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to conditionally build examples as it has been done for tests. Useful for packaging.
baylesj
requested changes
Nov 14, 2019
CMakeLists.txt
Outdated
| @@ -82,6 +82,7 @@ option(JSONCPP_WITH_WARNING_AS_ERROR "Force compilation to fail if a warning occ | |||
| option(JSONCPP_WITH_STRICT_ISO "Issue all the warnings demanded by strict ISO C and ISO C++" ON) | |||
| option(JSONCPP_WITH_PKGCONFIG_SUPPORT "Generate and install .pc files" ON) | |||
| option(JSONCPP_WITH_CMAKE_PACKAGE "Generate and install cmake package files" ON) | |||
| option(JSONCPP_WITH_EXAMPLE "Compile JsonCpp example" ON) | |||
There was a problem hiding this comment.
This means default on, right? Do we actually want to always build the example? I would vote for "opt in" not "opt out."
There was a problem hiding this comment.
Me too, we can check to OFF by default. I have based a PR on existing behaviour (to build an example).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to conditionally build examples as it has been done for tests.
Useful for packaging.