clang-tidy fixes again #1155
Merged
clang-tidy fixes again #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyDonahue
requested changes
Apr 11, 2020
|
Removed the static changes. |
BillyDonahue
requested changes
Apr 11, 2020
Found with readability-redundant-string-init Signed-off-by: Rosen Penev <[email protected]>
Easier to read. Found with modernize-raw-string-literal Signed-off-by: Rosen Penev <[email protected]>
|
Removed noexcept changes, |
|
I think the benefit of these macros is to maintain backward compatibility. |
|
This is currently not true as explicit and noexcept are already used in the code. |
BillyDonahue
requested changes
Apr 11, 2020
Found with performance* Signed-off-by: Rosen Penev <[email protected]>
Found with clang's -Wextra-semi-stmt Signed-off-by: Rosen Penev <[email protected]>
This codebase in C++11. No need for compatibility with C++98. Signed-off-by: Rosen Penev <[email protected]>
This codebase is C++11 now. No need for this macro. Signed-off-by: Rosen Penev <[email protected]>
|
This looks good to me. Thanks for being patient! |
dota17
added a commit
to dota17/jsoncpp
that referenced
this pull request
Apr 24, 2020
This reverts commit 90ca694.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easier to fun with meson.