optimize JsonWriter::validate #1172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyDonahue
commented
May 12, 2020
| if (valid_keys.find(key) == valid_keys.end()) { | ||
| inv[key] = settings_[key]; | ||
| } | ||
| static const auto& valid_keys = *new std::set<String>{ |
There was a problem hiding this comment.
There's no sense making a fresh valid_keys set each time validate is called.
Everybody can share one.
| if (invalid) | ||
| (*invalid)[std::move(key)] = *si; | ||
| else | ||
| return false; |
There was a problem hiding this comment.
If invalid==nullptr, then the caller will only get a pass/fail result.
We might as well return as soon as we know the answer.
| bool StreamWriterBuilder::validate(Json::Value* invalid) const { | ||
| Json::Value my_invalid; |
There was a problem hiding this comment.
This object is always a waste.
In the invalid==nullptr case, we populate this Value just to throw it away.
In the invalid!=nullptr case, we create it and never use it.
|
Subsumed by PR #1171. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion started in #1171