Skip to content

Try meson/ninja from pypi #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2020
Merged

Try meson/ninja from pypi #1229

merged 3 commits into from
Oct 10, 2020

Conversation

cdunn2001
Copy link
Contributor

On both linux and osx. If this works, we might be able to simplify.
However, we still want to test cmake, so there is only so much we
can simplify.

If this works, we might be able to stop using homebrew, if clang-format is available by default.

@coveralls
Copy link

coveralls commented Oct 10, 2020

Coverage Status

Coverage remained the same at 93.801% when pulling bb9db78 on pypi into c60ebf7 on master.

@cdunn2001
Copy link
Contributor Author

I am trying to figure out why TravisCI notification does not appear here, only AppVeyor. Possibly relevant: travis-ci/travis-ci#10204

@cdunn2001
Copy link
Contributor Author

Ok, I see TravisCI now. I added a "Branch Protection Rule" here: https://github.com/open-source-parsers/jsoncpp/settings/branches

This lets us simplify linux a little.

However, we still want to test cmake, so there is only so much we
can simplify.

For OSX, we still need `clang-format` from homebrew.

* Add PYTHONUSERBASE/bin to PATH for linux
@cdunn2001
Copy link
Contributor Author

I guess we don't need to wait for appveyor as long as everything else is good.

@cdunn2001 cdunn2001 merged commit 5f4e104 into master Oct 10, 2020
@baylesj baylesj deleted the pypi branch September 12, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants