Drop internal map #185
Merged
Drop internal map #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not tested via Travis (since this is outside cmake), but at least we can more easily validate changes to `amalgamate.py`.
And remove some old headers. These were not actually compiling anymore, and there were outstanding, known bugs, e.g. https://sourceforge.net/p/jsoncpp/bugs/27
cdunn2001
added a commit
that referenced
this pull request
Feb 25, 2015
`JSON_VALUE_USE_INTERNAL_MAP` and `JSON_USE_SIMPLE_INTERNAL_ALLOCATOR` did not actually compile with current compilers. In fact, as far as I can tell, they haven't worked since just after the 0.6.0-rc2 release. And according to blep, there are bugs, e.g. [this one](https://sourceforge.net/p/jsoncpp/bugs/27). It's probably better to hide the implementation of Value (maybe in the next major release) and to put experiments like this into completely separate classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON_VALUE_USE_INTERNAL_MAPandJSON_USE_SIMPLE_INTERNAL_ALLOCATORdid not actually compile with current compilers. In fact, as far as I can tell, they haven't worked since just after the 0.6.00-rc2 release. And according to blep, there are bugs, e.g. this one. It's probably better to hide the implementation of Value (maybe in the next major release) and to put experiments like this into completely separate classes.