Skip to content

Provide JSONCPP_DEPRECATED definitions for clang and gcc #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Dani-Hub
Copy link
Contributor

@Dani-Hub Dani-Hub commented Mar 8, 2015

Extended definitions of JSONCPP_DEPRECATED

@cdunn2001
Copy link
Contributor

Looks like there was a problem for gcc:

Building CXX object src/lib_json/CMakeFiles/jsoncpp_lib.dir/json_reader.cpp.o
In file included from /home/travis/build/open-source-parsers/jsoncpp/include/json/assertions.h:13:0,
                 from /home/travis/build/open-source-parsers/jsoncpp/src/lib_json/json_reader.cpp:7:
/home/travis/build/open-source-parsers/jsoncpp/include/json/config.h:73:45: error: missing binary operator before token "("

After you fix that, I'll try to test with VisualStudio.

@Dani-Hub
Copy link
Contributor Author

Dani-Hub commented Mar 8, 2015

Could you please provide me the gcc version (major and minor numbers or full version) that you have used for your testing?
[Some what later]: OK, I found that the provided test won't work for gcc versions smaller 5.0. I have now an improved test that works for all gcc versions that are available to me.

@Dani-Hub
Copy link
Contributor Author

Dani-Hub commented Mar 8, 2015

The revised commit has been tested successfully against gcc 4.3.6, 4.4.7, 4.5.4, 4.6.4, 4.7.3, 4.8.1, 4.9.0, 4.9.1, 4.9.2, and HEAD 5.0.0 as well as against clang 3.0, 3.1, 3.2, 3.3, 3.4, 3.5.0, 3.6.0, and HEAD 3.7.0 and finally against Visual Studio 2012

@cdunn2001 cdunn2001 mentioned this pull request Mar 8, 2015
@cdunn2001 cdunn2001 closed this in 3c0a383 Mar 8, 2015
@cdunn2001
Copy link
Contributor

Nice! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants