Skip to content

appveyor CI (msvc) #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

appveyor CI (msvc) #242

wants to merge 4 commits into from

Conversation

debris
Copy link
Contributor

@debris debris commented Apr 12, 2015

Just to check if everything works fine on windows. Configurations:

  • Debug Win32
  • Release Win32
  • Debug Win64
  • Release Win64

CI output:
https://ci.appveyor.com/project/debris/jsoncpp

@cdunn2001
Copy link
Contributor

This is great! Is there a way to make a GitHub push run these tests automatically, the way we do now with Travis CI?

Also, there has been some interest in pre-built binaries. If appveyor could automatically push Win artefacts into the GitHub release, some folks might like that.

@cdunn2001
Copy link
Contributor

Here is how. But we'll need a shared appveyor account. What do you suggest?

@debris
Copy link
Contributor Author

debris commented Apr 15, 2015

Sorry for late response, I was quite busy recently.

Also, there has been some interest in pre-built binaries. If appveyor could automatically push Win artefacts into the GitHub release, some folks might like that.

I will try to prepare this.

This version-string needs to be generated from cmake. CMakeLists.txt has the golden version name. Running cmake then updates 2 other files, and I add all 3 changes to the same commit. It's a bit counter-intuitive to include generated files in the commit, but it keeps everything consistent.
Maybe that version-string isn't really needed. Or just make it ${build}, ignoring the number.

I will just make it ${build}

Here is how. But we'll need a shared appveyor account. What do you suggest?

We don't need shared account. You can register there (with github account) and add jsoncpp to your projects. I've added there only my fork. And as well as Travis, it's free for opensource projects,

@cdunn2001
Copy link
Contributor

Can appveyor run automatically on a push? That's how Travis works today.

@debris
Copy link
Contributor Author

debris commented Apr 15, 2015

yes, it can :)

@cdunn2001 cdunn2001 mentioned this pull request Apr 17, 2015
@cdunn2001
Copy link
Contributor

Error parsing appveyor.yml: "version" value must be a string. (Line: 4, Column: 11)

Ok. Fixed that (in #244). Appveyor is kinda slow, but it works! If you're ok with the version-string change I made, I'll merge it in.

@cdunn2001
Copy link
Contributor

Merged (in #244, but they're still your commits). Thanks!

@cdunn2001 cdunn2001 closed this Apr 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants