Make 64-to-32 bit conversions explicit when needed (issue #296) #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
I just noticed that AppVeyor began to fail with this build: (I had assumed AppVeyor was down when I merged this change, but actually I just had to view it in another browser.) And the problem has affected someone else: #300. So I will have to revert this change, unless you have a more complete fix. |
|
@cdunn2001 - Sorry, I am new to AppVeyor, but I read one of the failed build logs and it looked like there were missing tools? Specifically: https://ci.appveyor.com/project/cdunn2001/jsoncpp/build/build.92/job/i2224pf8kr58y854#L55 says I am not sure how my changes caused that. Still, if you need to revert, I understand. |
|
Yeah, maybe we just need the Toolset. |
cdunn2001
added a commit
that referenced
this pull request
Jul 11, 2015
fix appveyor 32-bit windows build I've backed rebased under #297 because AppVeyor has been failing since there, and because that was not properly based on master anyway.
cdunn2001
pushed a commit
to cdunn2001/jsoncpp
that referenced
this pull request
Jul 11, 2015
…ed when needed This is rebased from open-source-parsers#297, where AppVeyor had been failing, and which was not properly based on the master branch.
Merged
cdunn2001
pushed a commit
to cdunn2001/jsoncpp
that referenced
this pull request
Jul 11, 2015
…ed when needed This is rebased from open-source-parsers#297, where AppVeyor had been failing, and which was not properly based on the master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.