-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Floating-point NaN or Infinity values should be allowed as a feature … #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…pen-source-parsers#209 Introduce 'allowSpecialFloats' for readers and 'useSpecialFloats' for writers, use consistent macro snprintf definition for writers and readers, provide new unit tests for open-source-parsers#209
…pen-source-parsers#209 Introduce 'allowSpecialFloats' for readers and 'useSpecialFloats' for writers, use consistent macro snprintf definition for writers and readers, provide new unit tests for open-source-parsers#209
I like this change. It seems good as-is. But I do have one idea: |
They are "just" conventions, but they are very popular ones, as described in the rationale of my issue #209. Please don't change these values lightheartedly, since doing that would break compatibility to gson, json5, simplejson, and probably several other json libraries. |
FYI: I did a little more testing and found a parsing bug. |
Billy danihub fix
…ty if we have a leading sign character.
Thanks for bug-finding test, Billy! The revised implementation should honor you test cases now properly. |
I'll try to cherry-pick this to 0.y.z too, but that's probably not a big deal. |
Floating-point NaN or Infinity values should be allowed as a feature …
Floating-point NaN or Infinity values should be allowed as a feature …
Merge pull request #339 from Dani-Hub/master
…#209
Introduce 'allowSpecialFloats' for readers and 'useSpecialFloats' for writers, use consistent macro snprintf definition for writers and readers, provide new unit tests for #209