Skip to content

Iterator conversions #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2015
Merged

Conversation

cdunn2001
Copy link
Contributor

No description provided.

does not compile
@cdunn2001
Copy link
Contributor Author

I had to undo #378 for binary-compatibility. Even though we do not want ConstIterator -> Iterator, we must keep the symbol. So we can just let it throw.

@cdunn2001 cdunn2001 force-pushed the issue-377 branch 2 times, most recently from cfc33a2 to 213fb26 Compare October 10, 2015 22:14
In value.h, ValueConstIterator can convert to ValueIterator, I think that is a bug. the correct way is ValueIterator can convert to ValueConstIterator.
cdunn2001 added a commit that referenced this pull request Oct 10, 2015
@cdunn2001 cdunn2001 merged commit 9c17e61 into open-source-parsers:master Oct 10, 2015
@cdunn2001 cdunn2001 deleted the issue-377 branch October 10, 2015 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants