std::snprintf not part of std for MinGW32 using c++11 #406
Conversation
|
It's surprising that the #define line is being checked for validity. I don't get that. Are we even using snprintf for anything in those files? If we need standard float formatting, we can probably get it more portably out of the ostream library. |
|
Hi @BillyDonahue, thanks for the quick reply. As you say snprintf is unused in the two files that caused me problems. I did not remove the definitions as I do not presume to know their purpose. Removing them will be an equably agreeable solution. I will update my pull request shortly! |
|
The only way the macros could affect you is if the token 'snprintf' is used in the expansion of a macro defined in one of the headers. But it isn't, so you're good. |
$ git grep -n snprintf
src/lib_json/json_reader.cpp:24:#define snprintf sprintf_s
src/lib_json/json_reader.cpp:26:#define snprintf std::snprintf
src/lib_json/json_reader.cpp:28:#define snprintf _snprintf
src/lib_json/json_reader.cpp:31:#define snprintf snprintf
src/lib_json/json_reader.cpp:33:#define snprintf std::snprintf
src/lib_json/json_reader.cpp:813: snprintf(buffer, sizeof(buffer), "Line %d, Col
src/lib_json/json_reader.cpp:1817: snprintf(buffer, sizeof(buffer), "Line %d, Co
...
|
std::snprintf not part of std for MinGW32 using c++11
Unfortunately MinGW32 (GCC 4.8.1-4) refuses to bulid jsoncpp. Giving the following error:
This issue has been covered before (#231 and #244). Although this is most likely a bug in MinGW32, but as the project is inactive (and it is still shipped with the Windows build of QtCreator), I propose to add the following if clause here. If MinGW32 is detected std::snprintf is not used, but simply the old C library snprintf instead.