Removed unneeded newlines from parsed comments #52
Conversation
|
Please add a test which fails before this change and passes after. Then we will merge this. |
|
Gladly. Is there anything in the testing infrastructure to compare the *.rewrite files with an expected file? Or to write comments to the *.actual files? |
|
Hmm. I don't know. I haven't done much work on the json-commenting code. |
This enables testing of comment-handling code. Updated *.expected test result files to account for printing of comments.
Newlines from comments separated by lines are retained when comments are appended, so adding a newline between separate comments for a node is not needed.
|
Okay, I modified the test runner jsoncpp/src/jsontestrunner/main.cpp to print comments to the *.actual files and updated the *.expected files accordingly. This causes some of the tests with multi-line comments to fail because of the unexpected extra newlines. The failures are corrected by the second commit fd06bfc which removes the extra newlines from comments. |
Removed unneeded newlines from parsed comments
|
Might revert if anyone complains, but looks good to me. Thanks. |
|
Great, thanks! |
Merged in upstream jsoncpp in pull request open-source-parsers/jsoncpp#52 Change-Id: Iae13e992765362399b23294b153c3ae1424704c0
Newlines from comments separated by lines are retained when comments
are appended, so adding a newline between separate comments for a
node is not needed.