Skip to content

Added stack overflow test #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 9, 2016
Merged

Conversation

jia3ep
Copy link
Contributor

@jia3ep jia3ep commented Nov 2, 2016

Added a test which tries to provoke stack overflow using the syntactically correct JSON file.

@cdunn2001
Copy link
Contributor

I think the global stack-limit applies only to the old, deprecated Reader, not to the new CharReaderBuilder. But I guess it doesn't hurt to prove that the limit/depth is working, if only you can get TravisCI to pass.

@jia3ep
Copy link
Contributor Author

jia3ep commented Nov 4, 2016

Yes, global variable is only used in Reader. Still I'll figure out why clang fails to compile in TravisCI.

@cdunn2001 cdunn2001 merged commit 77632b2 into open-source-parsers:master Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants