Skip to content

Fix warning issue with gcc flags. #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2017

Conversation

ya1gaurav
Copy link
Contributor

PR for - #586
Separating the default options for compiler flags.

PR for - open-source-parsers#586
Separating the default options for compiler flags.
FIx cmake build.
@cdunn2001
Copy link
Contributor

I don't understand the code existing before this PR. AND NOT JSONCPP_WITH_WARNING_AS ERROR? Seems like that was backward. I'll merge, but we'll revert if anybody complains.

(I've been traveling again, and out sick. Sorry for long delay.)

@cdunn2001 cdunn2001 merged commit 86ed860 into open-source-parsers:master Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants