Json::Value: Refactor common code in all constructors to an initBasic() function.

[BillyDonahue]

This reduces 8 lines to 2 lines in 12 places.
There shouldn't be a performance hit, as Value fields are POD.

[jacobsa]

Sigh, another argument for requiring C++11 (so that we can get delegated constructors). We should just go ahead and do it.

[BillyDonahue]

Thanks for the merge.

I think it may be too early to depend on C++11 expect in specialized builds. I've tried making C++11 extensions to jsoncpp and ran into some difficulty (experiment was on Mac). You have to be careful about any C++11 features that are exposed in the headers, because then every user has to compile with the same -std=c++11 flag that the library was built with, and this isn't the default. Managing that is going to be tricky, maybe requiring that a user produce different libraries for different language versions?

[cdunn2001]

Ugh! I thought C++11 would make life easier, not harder.

I should note that Debian just made their fork over the weekend, based on the current tip. So Debian will not have these int64 changes, etc.

Btw, did you know that Cereal (boost::serialization drop-in replacement) provides optional jsoncpp integration? I wouldn't be surprised if that were dropped someday, but it's there for now. Maybe you could learn something from Cereal's C++11 support.

[BillyDonahue]

@cdunn2001 : Cereal just unconditionally goes for it.
https://github.com/USCiLab/cereal/blob/master/CMakeLists.txt#L4

[cdunn2001]

I'm fine with that. If anybody cannot use C++11, then can check out from our pre-C++11 branch. If you don't modify the old code, then we can't break it! :-)