Move the existing value to "removed" argument; removed is optional (could be nullptr) #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim-ky
force-pushed
the
master
branch
2 times, most recently
from
c49f636 to
f9d0635
Compare
|
looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
There're two commits here.
The first one could be considered to be a minor bug fix (std::move).
The second one is disputable. It slightly changes Value::removeMember interface, so it could take nullptr as the "removed" argument. It seems to be a pretty common use case since that extra returned value is not needed for everyone. Also, changing tons of code to support the new removeMember interface could be much easier with this nullptr-feature.
Regards