Skip to content

Fix msvc /fp:fast test failure #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2018

Conversation

fo40225
Copy link
Contributor

@fo40225 fo40225 commented May 5, 2018

fix #767

@cdunn2001
Copy link
Contributor

../src/test_lib_json/main.cpp:2408:28: error: ‘isnan’ was not declared in this scope
     JSONTEST_ASSERT(isnan(n));

This change is fine, but it needs to pass TravisCI too. Maybe we need #include <cmath>, or std::isnan().

@cdunn2001 cdunn2001 merged commit 2cc9b24 into open-source-parsers:master May 8, 2018
@cdunn2001
Copy link
Contributor

Very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test fail when use /fp:fast with msvc
2 participants