Skip to content

Fix for #798 #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

cinemast
Copy link
Contributor

Add preprocessor definitions for MSVC dllexport/dllimport statements

Add preprocessor definitions for MSVC dllexport/dllimport statements
@cinemast
Copy link
Contributor Author

I don't know why the gcc build is failing. It does not seem to be related to the changes.

@cdunn2001
Copy link
Contributor

TravisCI might have deleted gcc-4.9. I'm asking them for advice on how to proceed.

@cdunn2001
Copy link
Contributor

This passed 6 days ago: https://travis-ci.org/open-source-parsers/jsoncpp/builds/393044263?utm_source=github_status&utm_medium=notification

Maybe TravisCI changed very recently.

@cdunn2001 cdunn2001 self-assigned this Jun 22, 2018
@cdunn2001
Copy link
Contributor

Hmmm. This is strange. Your base commit rebuilds fine:

I've rebased your change onto our master, and it still fails:

I think the problem may be the '' here (after fPIC):

g++-4.9 -Ijsoncpp@sha -I. -I.. -I../include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall\
 -Winvalid-pch -Wnon-virtual-dtor -std=c++11 -O0 -g -fPIC ''  -MD \
 -MQ 'jsoncpp@sha/src_lib_json_json_value.cpp.o' \
 -MF 'jsoncpp@sha/src_lib_json_json_value.cpp.o.d' \
 -o 'jsoncpp@sha/src_lib_json_json_value.cpp.o' -c ../src/lib_json/json_value.cpp

I think your new string is being substituted wrong...

@cdunn2001
Copy link
Contributor

Yes, a successful run has this:

[1/9] g++-4.9 -Ijsoncpp_test@exe -I. -I.. -I../include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++11 -O3  -MD -MQ 'jsoncpp_test@exe/src_test_lib_json_jsontest.cpp.o' -MF 'jsoncpp_test@exe/src_test_lib_json_jsontest.cpp.o.d' -o 'jsoncpp_test@exe/src_test_lib_json_jsontest.cpp.o' -c ../src/test_lib_json/jsontest.cpp

For some reason, clang doesn't mind the empty-string argument, but g++ has a problem with it.

@cdunn2001
Copy link
Contributor

Meson needs [] instead of '' for empty-string. Fixing in #800.

@cdunn2001 cdunn2001 closed this in c00a3b9 Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants