Modify code comments in write.h #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyDonahue
requested changes
Jul 15, 2019
BillyDonahue
requested changes
Jul 15, 2019
|
Why are we bothering with C-style comments? Why not just move everything over to C++ style comments (e.g. //)? |
Hi @baylesj I follow the C style comment in the other place of this project(e.g. read.h value.h), just to keep it consistent. but if you perfer to C++ style, I'd like to apply it in this whole project, and before that, we should close this PR or merge it. |
baylesj
approved these changes
Sep 16, 2019
dawesc
pushed a commit
to EFTlab/jsoncpp
that referenced
this pull request
Sep 25, 2019
* modify code comments in write.h * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing file write.h in issue #985