Skip to content

Conversation

DylanRussell
Copy link
Contributor

@DylanRussell DylanRussell commented Jul 7, 2025

Description

Basically just a continuation of #4597. My PR just updates the API LogRecord to match what the SDK LogRecord does with context..

This will help me migrate instrumentations using the API Event to use the API LogRecord,.. I ran into an issue migrating one of the instrumentations that relies on EventsLogger.emit getting the context and using it to set trace/spanid: https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-sdk/src/opentelemetry/sdk/_events/__init__.py#L52

There is no equivalent logic in the Logger, but this PR adds it..

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tests

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • [x ] No.

Checklist:

  • [ x] Followed the style guidelines of this project
  • Changelogs have been updated
  • [ x] Unit tests have been added
  • [ x] Documentation has been updated

@DylanRussell DylanRussell requested a review from a team as a code owner July 7, 2025 20:45
@DylanRussell
Copy link
Contributor Author

@emdneto @tammy-baylis-swi can I get your thoughts/reviews on this PR ?

@tammy-baylis-swi
Copy link
Contributor

I think this is good. It's safer than changing the LogRecord init by the Event API immediately to pass context instead of trace_id etc, plus wherever else.

DylanRussell and others added 2 commits July 8, 2025 11:17
…rd' of github.com:DylanRussell/opentelemetry-python into add_context_to_logrecord
@lzchen lzchen merged commit 0a2df97 into open-telemetry:main Jul 9, 2025
375 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants