Feat: Add support for pattern properties #2288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: b5ccff0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@gzm0 yes please feel free to review! The round-robin assignment was only meant to divide the PR reviews among us evenly, but always feel free to jump in and stamp a PR if you have context/time |
gzm0
requested changes
May 26, 2025
|
Any more movement on this? |
hontas
force-pushed
the
pattern-properties
branch
from
b299279 to
50ad586
Compare
|
@gzm0 thanks for the feedback! |
VaiTon
added a commit
to openfoodfacts/openfoodfacts-js
that referenced
this pull request
Sep 7, 2025
…repo and enhance type definitions in v2 and v3 schemas Until openapi-ts/openapi-typescript#2288 is merged we can use a fork to have the patternProperties openapi spec included into the generated typing
gzm0
requested changes
Sep 19, 2025
|
@gzm0 no worries. Good catch - updated 👍 |
gzm0
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add support for patternProperties in addition to additionalProperties (#754).
Building on the work of @gzm0 in 1901 by adding tests
Ran the command
pnpm run update:exampleswhich created 129 new files and updated 69, none of which seemed related to this change. Let me know if you wan't me to do it anyways.How to Review
Refer to comments in original PR 1901
Validate tests are satisfactory
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)