translate ch-comments to en-comments #2927
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: koko2pp <[email protected]>
|
cicheck |
Signed-off-by: koko2pp <[email protected]>
Ziy1-Tan
reviewed
Nov 29, 2023
| * IO performance statistics composite metric type | ||
| */ | ||
| struct IoPerfMetric { | ||
| uint64_t readCount; |
There was a problem hiding this comment.
Comment translation should not break the original code format.
| */ | ||
| inline GroupNid ToGroupNid(const LogicPoolID &logicPoolId, | ||
| const CopysetID ©setId) { | ||
| inline GroupNid ToGroupNid(const LogicPoolID& logicPoolId, |
|
repeated with #2754 and ensure it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2576
Problem Summary: translate Chinese annotations to English annotations
What is changed and how it works?
What's Changed: The Chinese comments in the code files have been converted into English comments.
How it Works: Write a GO script. For various programming languages, extract all comments from code files using different regular expressions, then determine whether the comments contain Chinese characters. If there are Chinese characters, use the Baidu Translate API to translate the Chinese comments into English comments, and then write them back to the file.
Side effects(Breaking backward compatibility? Performance regression?): None
Check List
[1] Relevant documentation/comments is changed or added
[1] I acknowledge that all my contributions will be made under the project's license