test: next.js repo tests adjustments #3168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
commented
Oct 8, 2025
Comment on lines
+240
to
+241
| IS_WEBPACK_TEST: ${{ steps.decide-default-bundler.outputs.default_bundler == 'webpack' && '1' || '' }} | ||
| IS_TURBOPACK_TEST: ${{ steps.decide-default-bundler.outputs.default_bundler == 'turbopack' && '1' || '' }} |
There was a problem hiding this comment.
those env vars are used by next test helpers and will impact isTurbopack etc checks - for example like one used in this test https://github.com/vercel/next.js/blob/a7d3aecafedc920221a885b8ab00f35f6de5e91c/test/e2e/esm-externals/esm-externals.test.ts
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
commented
Oct 8, 2025
Comment on lines
+70
to
+84
| if ( | ||
| typeof this.files === 'string' && | ||
| this.files.includes('back-forward-cache') && | ||
| process.env.NEXT_RESOLVED_VERSION && | ||
| satisfiesVersionRange(process.env.NEXT_RESOLVED_VERSION, '<=15.5.4') | ||
| ) { | ||
| require('console').log('Pinning @types/react(-dom) for back-forward-cache test fixture') | ||
| // back-forward-cache test fixture is failing types checking because: | ||
| // - @types/react(-dom) types are not pinned | ||
| // - fixture uses react `unstable_Activity` export which since fixture was introduced is no longer unstable | ||
| // and types were updated for that and no longer provide types for that export (instead provide for `Activity`) | ||
| // this adds the pinning of types to version of types that still had `unstable_Activity` type | ||
| this.dependencies['@types/react'] = '19.1.1' | ||
| this.dependencies['@types/react-dom'] = '19.1.2' | ||
| } |
There was a problem hiding this comment.
this is something that would fail on next.js repo as well if they run the test against current latest. The test was updated in canary, but not in latest.
I don't love this hack, but this test generally passes and I'd rather not skip it. Creating triaging issue doesn't make much sense either, so only option left is to "patch" the test when we run against current latest
pieh
commented
Oct 8, 2025
Comment on lines
+86
to
+88
| if (!this.buildCommand && this.buildArgs && this.buildArgs.length > 0) { | ||
| this.buildCommand = `next build ${this.buildArgs.join(' ')}` | ||
| } |
There was a problem hiding this comment.
This is to support this test https://github.com/vercel/next.js/blob/a7d3aecafedc920221a885b8ab00f35f6de5e91c/test/e2e/react-compiler/react-compiler.test.ts#L42 , without something like this --profile would not be applied and test rely on react profiling being enabled
pieh
commented
Oct 8, 2025
Comment on lines
+64
to
+68
| this.dependencies = { | ||
| ...(this.dependencies || {}), | ||
| // add the runtime package as a dependency | ||
| [runtimePackageName]: `file:${runtimePackageTarballPath}`, | ||
| } |
There was a problem hiding this comment.
this isn't strictly needed change, but I do find it nicer to let next.js repo e2e utils to just produce package.json that has our runtime as dependency, instead of adding it as part of installation
especially as I used this.dependencies below to "fix" a test setup for us, so all the things messing with deps is using single way of doing that
pieh
force-pushed
the
test-e2e-vercel-nextjs-adjustments
branch
from
5c2900b to
ebe626f
Compare
mrstork
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See inline comments or code comments for details of changes