Skip to content

fix: support revalidateTag SWR in 'use cache' handler #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 21, 2025
Merged

fix: support revalidateTag SWR in 'use cache' handler #3180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9530f42
test: update to work with next@canary
pieh Oct 16, 2025
0eab4e4
test: nx linux issue workaround
pieh Oct 16, 2025
980e981
test: add 'use cache' test with SWR revalidateTag
pieh Oct 15, 2025
4450408
fix: support revalidateTag SWR in 'use cache' handler
pieh Oct 15, 2025
ef1ecc4
perf: dedupe tag revalidations
pieh Oct 15, 2025
f7942b8
test: bump number of retries on next.js repo tests
pieh Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/test-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ on:
pull_request:
branches: [main]
schedule:
- cron: '0 3 * * *' # Run every day at 3am UTC
- cron: "0 3 * * *" # Run every day at 3am UTC
workflow_dispatch:
inputs:
versions:
description: 'The versions of Next.js to test against (escape-quoted and comma separated)'
description: "The versions of Next.js to test against (escape-quoted and comma separated)"
required: false
# TODO(serhalp) Ideally this would simply accept bare quotes but we're having trouble
# parsing that so this will do for now.
Expand Down Expand Up @@ -52,7 +52,6 @@ jobs:
group: ${{ steps.set-matrix.outputs.group }}
total: ${{ steps.set-matrix.outputs.total }}
steps:

- name: Set Next.js versions to test
id: set-matrix
run: |
Expand Down Expand Up @@ -240,7 +239,7 @@ jobs:
IS_WEBPACK_TEST: ${{ steps.decide-default-bundler.outputs.default_bundler == 'webpack' && '1' || '' }}
IS_TURBOPACK_TEST: ${{ steps.decide-default-bundler.outputs.default_bundler == 'turbopack' && '1' || '' }}
NODE_OPTIONS: --import ${{ github.workspace }}/${{ env.runtime-path}}/tools/fetch-retry.mjs
run: node run-tests.js -g ${{ matrix.group }}/${{ needs.setup.outputs.total }} -c ${TEST_CONCURRENCY} --type e2e
run: node run-tests.js -g ${{ matrix.group }}/${{ needs.setup.outputs.total }} -c ${TEST_CONCURRENCY} --type e2e --retries 5
working-directory: ${{ env.next-path }}

- name: Upload Test Results
Expand All @@ -250,7 +249,7 @@ jobs:
name: test-result-${{matrix.version_spec.selector}}-${{ matrix.group }}
path: ${{ env.next-path }}/test/${{steps.decide-default-bundler.outputs.default_bundler == 'turbopack' && 'turbopack-test-junit-report' || 'test-junit-report'}}/*.xml
publish-test-results:
name: 'E2E Test Summary (${{matrix.version_spec.selector}})'
name: "E2E Test Summary (${{matrix.version_spec.selector}})"
needs:
- e2e
- setup
Expand Down
Loading
Loading