test: deflake and another next 16 compat update for fixtures #3181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
added
the
test latest and canary
📊 Package size report 0.01%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
commented
Oct 16, 2025
| expect(response2?.status()).toBe(200) | ||
| expect(response2?.headers()['cache-status']).toMatch( | ||
| /("Netlify Edge"; hit; fwd=stale|"Netlify Durable"; hit; ttl=-[0-9]+)/m, | ||
| /("Netlify Edge"; fwd=stale|"Netlify Durable"; hit; ttl=-[0-9]+)/m, |
There was a problem hiding this comment.
the Netlify Edge one was wrong for quite some time so this in practice was relying on hitting durable cache case
pieh
commented
Oct 16, 2025
| } catch (error) { | ||
| let shouldRetry = false | ||
| // not ideal, but there is no error code for that | ||
| if (error.message === 'fetch failed' && attempt < NUM_RETRIES) { |
There was a problem hiding this comment.
this is happening very randomly and does not seem related to any specific fetch target:
- it might be happening in fetch that CLI is doing to fetch extensions and result in confusing error about site not being linked (even tho we specifically pass site_id to cli command in our e2e tests)
- it might be happening in data fetches in fixtures (both when preparing fixtures for integration tests and when building and deploying for e2e tests)
it seems more related to runners and hitting potential limits there
PS. I do hate it, but have no better idea as this would have to be replicated in a lot of places, some of which we don't control
pieh
commented
Oct 16, 2025
| @@ -1,4 +1,4 @@ | |||
| import { unstable_cacheLife as cacheLife, unstable_cacheTag as cacheTag } from 'next/cache' | |||
| import { cacheLife, cacheTag } from '../../../../../next-cache' | |||
There was a problem hiding this comment.
unstable_cacheLife no longer exist in next@canary - it's just cacheLife now
But because we still will be running tests for next@15 I did add helper module for compatibility that will use either export with unstable_ prefix or stable one, depending on which is available in tested next.js version
pieh
commented
Oct 16, 2025
Comment on lines
+545
to
+556
| env: { | ||
| NX_ISOLATE_PLUGINS: 'false', | ||
| }, | ||
| }), | ||
| nxIntegratedDistDir: () => | ||
| createE2EFixture('nx-integrated', { | ||
| packagePath: 'apps/custom-dist-dir', | ||
| buildCommand: 'nx run custom-dist-dir:build', | ||
| publishDirectory: 'dist/apps/custom-dist-dir/dist', | ||
| env: { | ||
| NX_ISOLATE_PLUGINS: 'false', | ||
| }, |
There was a problem hiding this comment.
nx on next canary starting failing with errors mentioned in nrwl/nx#27040 (but it's not exactly the same, because issue mention postinstall, while for us errors were happening at next build time, so despite that issue being closed with a fix, I think we are hitting similar problem in different place). I tried NX_ISOLATE_PLUGINS which was suggested as workaround there and that seemed to work here as well
pieh
force-pushed
the
test-deflake-and-next-16-update
branch
from
b430591 to
0e951a2
Compare
pieh
changed the title
|
I'll close this as some adjustments were merged separately and some are included in #3180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation
Tests
You can test this change yourself like so:
Relevant links (GitHub issues, etc.) or a picture of cute animal