mkbuildinf: Strip fdebug-prefix-map from saved CFLAGS #11545
Conversation
|
ping |
t8m
added
branch: master
|
A gentle ping. |
|
You'll want to update this to also handle -fmacro-prefix-map and -ffile-prefix-map (which is a combination of -fdebug-prefix-map and -fmacro-prefix-map). Since Debian's bullseye release, -ffile-prefix-map has been in the defaults that builds using dpkg-buildflags will use. |
kroeckx
added
the
waiting-for: contributor response
|
@sebastianas This seems to be waiting for changes from you |
The saved `CFLAGS' may contain the `-fdebug-prefix-map=' which is used to strip the build path from the debug info. If this information remains recorded then the binary is no longer reproducible if the build directory changes. Replace the recorded CFLAG parameter `-fdebug-prefix-map=$OLD=$NEW" with `-fdebug-prefix-map=<REPRODUCIBLE>'. Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
sebastianas
force-pushed
the
reproducible
branch
from
436f148 to
0287fce
Compare
|
This PR is waiting for the creator to make requested changes but it has not been updated for 30 days. If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section). |
paulidale
left a comment
paulidale
left a comment
There was a problem hiding this comment.
I think that this should either be enabled via a configure option or disabled for debug builds. I'm not sure which is the better choice. Suggestions anyone?
|
What would be the scenario for this to be useful? That would probably make it easier to decide. |
|
This option breaks debuggers. I think that that is a very bad thing to do by default. I know that debuggers can be told the correct source address but I'm confident that a lot of folks wouldn't know how to do this. By making this an enableable (but disabled by default) option, the user is making the choice to break their debugger. Likewise, by not enabling this in debug builds, it's less invasive. |
|
This PR is waiting for the creator to make requested changes but it has not been updated for 30 days. If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section). |
|
This PR is waiting for the creator to make requested changes but it has not been updated for 61 days. If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section). |
|
This PR has been closed. It was waiting for the creator to make requested changes but it has not been updated for 90 days. |
6 participants
The saved
CFLAGSmay contain the-fdebug-prefix-map=which is usedto strip the build path from the debug info. If this information remains
recorded then the binary is no longer reproducible if the build
directory changes.
Replace the recorded CFLAG parameter
-fdebug-prefix-map=$OLD=$NEWwith-fdebug-prefix-map=<REPRODUCIBLE>.Signed-off-by: Sebastian Andrzej Siewior [email protected]
Checklist