Add preset for device_charging_station
#1611
Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
There was a problem hiding this comment.
Thanks for the PR. Here is a quick review:
- Please add the PR test recommendations.
- I added a few inline comments to review.
- The wiki also recommends fields like
accesswhich sound reasonable to me (customers vs. public for example) https://wiki.openstreetmap.org/wiki/Tag:amenity%3Ddevice_charging_station
Please review the fields by comparing the wiki suggestions with the once below from actual usage.
Usage based on postpass:
curl -g https://postpass.geofabrik.de/api/0.2/inter
preter \
> --data-urlencode "options[geojson]=false" \
> --data-urlencode "data=SELECT key, COUNT(*) AS count FROM postpass_pointlinepo
lygon, jsonb_each_text(tags) AS t(key, value) WHERE tags->>'amenity' = 'device_c
harging_station' GROUP BY key ORDER BY count DESC"
(Only > 2)
SHOW LIST…
{
"key": "amenity",
"count": 1085
},
{
"key": "fee",
"count": 518
},
{
"key": "socket:device:USB-A",
"count": 456
},
{
"key": "capacity",
"count": 316
},
{
"key": "lockable",
"count": 316
},
{
"key": "level",
"count": 256
},
{
"key": "access",
"count": 241
},
{
"key": "name",
"count": 236
},
{
"key": "opening_hours",
"count": 232
},
{
"key": "operator",
"count": 165
},
{
"key": "socket:typee",
"count": 124
},
{
"key": "support",
"count": 122
},
{
"key": "emergency",
"count": 122
},
{
"key": "colour",
"count": 113
},
{
"key": "description",
"count": 75
},
{
"key": "socket",
"count": 71
},
{
"key": "surveillance",
"count": 58
},
{
"key": "check_date",
"count": 56
},
{
"key": "voltage",
"count": 47
},
{
"key": "website",
"count": 40
},
{
"key": "socket:device:USB-C",
"count": 38
},
{
"key": "wheelchair",
"count": 33
},
{
"key": "socket:schuko",
"count": 32
},
{
"key": "email",
"count": 30
},
{
"key": "phone",
"count": 29
},
{
"key": "internet_access",
"count": 28
},
{
"key": "payment:app",
"count": 27
},
{
"key": "socket:device:qi-wireless",
"count": 26
},
{
"key": "indoor",
"count": 26
},
{
"key": "source",
"count": 24
},
{
"key": "power",
"count": 20
},
{
"key": "note",
"count": 20
},
{
"key": "socket:device:lightning",
"count": 20
},
{
"key": "brand",
"count": 19
},
{
"key": "internet_access:fee",
"count": 19
},
{
"key": "covered",
"count": 18
},
{
"key": "socket:USB",
"count": 16
},
{
"key": "socket:device:micro-b",
"count": 15
},
{
"key": "bench",
"count": 14
},
{
"key": "generator:source",
"count": 14
},
{
"key": "lit",
"count": 14
},
{
"key": "socket:typeb",
"count": 14
},
{
"key": "amperage",
"count": 13
},
{
"key": "start_date",
"count": 13
},
{
"key": "socket:nema_5_15",
"count": 12
},
{
"key": "addr:city",
"count": 12
},
{
"key": "tactile_paving",
"count": 11
},
{
"key": "socket:device:Micro-B",
"count": 11
},
{
"key": "socket:device:USB-A:current",
"count": 11
},
{
"key": "socket:nema_1_15",
"count": 10
},
{
"key": "shop",
"count": 10
},
{
"key": "socket:device:USB-A:voltage",
"count": 10
},
{
"key": "frequency",
"count": 10
},
{
"key": "addr:street",
"count": 9
},
{
"key": "leisure",
"count": 9
},
{
"key": "airside",
"count": 8
},
{
"key": "material",
"count": 8
},
{
"key": "payment:coins",
"count": 8
},
{
"key": "smoking",
"count": 7
},
{
"key": "ref",
"count": 7
},
{
"key": "contact:website",
"count": 7
},
{
"key": "location",
"count": 7
},
{
"key": "highway",
"count": 7
},
{
"key": "payment:debit_cards",
"count": 6
},
{
"key": "bicycle",
"count": 6
},
{
"key": "bin",
"count": 6
},
{
"key": "fixme",
"count": 6
},
{
"key": "generator:method",
"count": 6
},
{
"key": "payment:notes",
"count": 6
},
{
"key": "payment:electronic_purses",
"count": 6
},
{
"key": "layer",
"count": 6
},
{
"key": "operator:wikidata",
"count": 6
},
{
"key": "payment:cryptocurrencies",
"count": 6
},
{
"key": "payment:credit_cards",
"count": 6
},
{
"key": "power_supply",
"count": 5
},
{
"key": "model",
"count": 5
},
{
"key": "tourism",
"count": 5
},
{
"key": "operator:type",
"count": 5
},
{
"key": "generator:type",
"count": 5
},
{
"key": "generator:output:electricity",
"count": 5
},
{
"key": "motorcar",
"count": 4
},
{
"key": "internet_access:ssid",
"count": 4
},
{
"key": "shelter",
"count": 4
},
{
"key": "public_transport",
"count": 4
},
{
"key": "man_made",
"count": 4
},
{
"key": "manufacturer",
"count": 4
},
{
"key": "bus",
"count": 4
},
{
"key": "building",
"count": 4
},
{
"key": "addr:postcode",
"count": 4
},
{
"key": "wikimedia_commons",
"count": 3
},
{
"key": "addr:housenumber",
"count": 3
},
{
"key": "building:material",
"count": 3
},
{
"key": "description:de",
"count": 3
},
{
"key": "maxstay",
"count": 3
},
{
"key": "socket:bs1363",
"count": 3
},
{
"key": "socket:device:lightning_cable",
"count": 3
},
{
"key": "socket:device:USB-C_cable",
"count": 3
},
{
"key": "socket:nema_5_20",
"count": 3
},
{
"key": "socket:schuko:voltage",
"count": 3
},
{
"key": "socket:usb",
"count": 3
},
{
"key": "survey:date",
"count": 3
},| "operator", | ||
| "capacity", | ||
| "fee", | ||
| "indoor", |
There was a problem hiding this comment.
| "indoor", |
Are there any non indoor? This is not on the wiki.
There was a problem hiding this comment.
There are five: https://overpass-turbo.eu/s/26Rx
Thus around 20% of those with the "indoor" tag.
There was a problem hiding this comment.
Given that it is so rare (and sufficiently unexpected that I suspect tagging errors, I would ask mappers if I would not be on bus)
I would put it into moreFields so it is not shown by default
There was a problem hiding this comment.
Made some probing changeset comments in the end
…tagging-schema into add_device_charging_station
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
Test-DocumentationPreview links & Sidebar Screenshotshttps://www.openstreetmap.org/node/10313144876#map=19/50.329905/7.224757 Search
Info-
|
|
@matkoniecz I think this looks good. Could you give this a review? Will add the "ready for merge tag" and merge next "round". There is the open question if we would rather want to remove the |
tordans
added
the
waiting-ready-to-merge
I don't understand why? |
Because we want to be careful which tags to promote via fields and in my mind an outdoor charging station is something very unexpected. We don't want fields that are answered with "no" all the time by users just because they are very visible. This is not even in the
The bus stop would then be Are there really uncovered charing stations (in a relevant number that we want to handle those in a preset)? This would be easier if there where example images with tags in https://wiki.openstreetmap.org/wiki/Tag:amenity%3Ddevice_charging_station for those cases… but the tag is not even mentioned there… |
|
Given #1611 (comment) I moved it to |
tordans
changed the title
device_charging_station
|
Thanks for moving this along @paulklie |
4 participants
Description, Motivation & Context
Adds the amenity=device_charging_station preset.
Related issues
Closes #1359
Links and data
amenity=device_charging_station
Relevant tag usage stats:
taginfo: 1084 uses
Checklist and Test-Documentation Template
I seem to be unable to post screenshots here, hope this suffices. The Infobox works
Test-Documentation
Preview links & Sidebar Screenshots
https://imgur.com/a/seYQ89i
https://www.openstreetmap.org/node/9983467989
Search
https://imgur.com/a/x57uggB
Info-
ihttps://imgur.com/a/GeQBaRf
Wording
name,aliases(if present) use Title Caseterms(if present) use lower case, sorted A-Z