Skip to content

Conversation

@novolife
Copy link
Contributor

@novolife novolife commented Oct 21, 2025

Description, Motivation & Context

An icon for Paifang

Related issues

rapideditor/temaki#96

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

698

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@novolife
Copy link
Contributor Author

Maybe it is not synchronized with temaki yet, close this PR

@novolife novolife closed this Oct 21, 2025
@tyrasd tyrasd added the waitfor-icon a matching icon is missing for this preset label Oct 21, 2025
@tyrasd
Copy link
Member

tyrasd commented Oct 21, 2025

We need to wait until the icon is included in a published release of temaki.

@novolife can you please come back in a few weeks and reopen once a new temaki release is out?

@novolife
Copy link
Contributor Author

novolife commented Oct 22, 2025

@novolife can you please come back in a few weeks and reopen once a new temaki release is out?

Sure, I see that Temaki has a new release. I will open it again when it is OK here.

@tyrasd tyrasd reopened this Oct 22, 2025
@tyrasd tyrasd added new-icon and removed waitfor-icon a matching icon is missing for this preset labels Oct 22, 2025
@tyrasd tyrasd merged commit b415629 into openstreetmap:main Oct 22, 2025
10 checks passed
@novolife novolife deleted the paifang branch October 24, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants