Fixes flakey ZipkinExtensionTest #3631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attempts to fix, rather than ignore (which was done previously and I removed in the last commit) a flakey test. It appears likely that not using resource management at all in this test could result in flakes. Even if not, it is worth removing doubt around this. ``` Error: Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.739 s <<< FAILURE! -- in zipkin2.junit5.ZipkinExtensionTest Error: zipkin2.junit5.ZipkinExtensionTest.postSpans_disconnectDuringBody -- Time elapsed: 0.054 s <<< ERROR! java.io.IOException: unexpected end of stream on http://localhost:53245/... at okhttp3.internal.http1.Http1ExchangeCodec.readResponseHeaders(Http1ExchangeCodec.kt:209) --snip-- Caused by: java.io.EOFException: \n not found: limit=0 content=… at okio.RealBufferedSource.readUtf8LineStrict(RealBufferedSource.kt:332) at okhttp3.internal.http1.HeadersReader.readLine(HeadersReader.kt:29) at okhttp3.internal.http1.Http1ExchangeCodec.readResponseHeaders(Http1ExchangeCodec.kt:179) ... 84 more ``` Signed-off-by: Adrian Cole <[email protected]>
anuraaga
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix, rather than ignore (which was done previously and I removed in the last commit) a flakey test. It appears likely that not using resource management at all in this test could result in flakes. Even if not, it is worth removing doubt around this.