-
Notifications
You must be signed in to change notification settings - Fork 232
fabric8 next version daily check #1856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7e19a3e to
fe9491f
Compare
| paths-ignore: | ||
| - 'docs/**' | ||
| branches: [ main, v1, v2, v3, next ] | ||
| branches: [ fabric8-next-version ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep releasing snapshots for main as well. Ideally, on every merge, even, which would mean splitting this out. Don't know. A snapshot a day is probably enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK it works in a way that, this is not merged, so the github action will for this branch will take into account only the code on this branch. So since this PR never will be merged this should be enough to run the releases daily for this branch, but will work also for main (since that run uses the code from there)
.github/workflows/pr.yml
Outdated
| on: | ||
| schedule: | ||
| # Run on end of the day | ||
| - cron: '0 0 * * *' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this added? Is it meant to run a build at least once a day?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, to run a daily build.
cec7be5 to
60b937f
Compare
60b937f to
c2c6513
Compare
dd30ae2 to
cb97374
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
cb97374 to
756b59f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
756b59f to
2a19a20
Compare
bdc0b7c to
903267c
Compare
903267c to
78c6145
Compare
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
17f6030 to
756c4d1
Compare
|
Why did you close this PR, @csviri? |
|
Hmm, I did not, I just updated it for the main, and since there is no snapshot of fabric8 (tried 7.0.2-SNAPSHOT and 7.1.0-SNAPSHOT) I set it for the latest version, so github closed it. Do you know what is the latest snapshot? |
|
Next version is |
|
that cannot be found. |
|
It's possible that they haven't been deployed, yet. |
|
yeah, I gues so, will recreate this PR with that version. |








!! DON'T MERGE !!
The goal of this PR is to test the framework with the most recent version of fabric8 client.