Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -113,22 +113,9 @@ public <R extends HasMetadata> ControllerConfiguration<R> getConfigurationFor(
Reconciler<R> reconciler) {
final var key = keyFor(reconciler);
final var configuration = configurations.get(key);
if (configuration == null) {
logMissingReconcilerWarning(key, getReconcilersNameMessage());
}
return configuration;
}

protected void logMissingReconcilerWarning(String reconcilerKey, String reconcilersNameMessage) {
log.warn("Cannot find reconciler named '{}'. {}", reconcilerKey, reconcilersNameMessage);
}

private String getReconcilersNameMessage() {
return "Known reconcilers: "
+ getKnownReconcilerNames().stream().reduce((s, s2) -> s + ", " + s2).orElse("None")
+ ".";
}

protected <R extends HasMetadata> String keyFor(Reconciler<R> reconciler) {
return ReconcilerUtils.getNameFor(reconciler);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,14 +147,6 @@ private static void configureFromAnnotatedReconciler(
}
}

@Override
protected void logMissingReconcilerWarning(String reconcilerKey, String reconcilersNameMessage) {
logger.warn(
"Configuration for reconciler '{}' was not found. {}",
reconcilerKey,
reconcilersNameMessage);
}

@SuppressWarnings("unused")
public String getLoggerName() {
return LOGGER_NAME;
Expand Down